Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to ufs.configure for use in global applications #2074

Closed
wants to merge 13 commits into from
Closed

Updates to ufs.configure for use in global applications #2074

wants to merge 13 commits into from
+780 −89

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jan 4, 2024 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  • Add list of all failed regression tests in "Regression Tests" section

Description

This PR:

  • updates several templates ufs.configure.*.IN used in the global applications so that they can be shared between the ufs-weather-model regression testing framework and the global applications.
  • moves the templates by adding _esmf for ESMF-managed threading and _fast where the wave coupling is in the fast loop (as opposed to _slow where it was in the slow loop)
  • updates the files under tests/ to use the appropriately renamed template.

Commit Message

Updates ufs.configure templates for use in global-applications.

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, GFSv17, GEFSv13))
  • Normal

Blocking Dependencies

Git Issues Fixed By This PR

Part of #2010

Changes

Subcomponent (with links)

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
FAILED REGRESSION TESTS

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@aerorahul aerorahul marked this pull request as ready for review January 5, 2024 19:26
@junwang-noaa
Copy link
Collaborator

@NickSzapiro-NOAA would you please review and test this PR? Thanks

@NickSzapiro-NOAA
Copy link
Collaborator

The tests/parm/ufs.configure.s2sw* need user_sets_restname = true for the WW3 restart files to pass restart regression tests

@NickSzapiro-NOAA
Copy link
Collaborator

Modify export UFS_CONFIGURE=ufs.configure.s2sw.IN in tests/tests/cpld_control_gfsv17 as well

@aerorahul
Copy link
Contributor Author

Modify export UFS_CONFIGURE=ufs.configure.s2sw.IN in tests/tests/cpld_control_gfsv17 as well

Thanks for catching this. Done in 1f33a4b

@DeniseWorthen
Copy link
Collaborator

@NickSzapiro-NOAA Are you running the RTs for this PR in order to post the logs?

@NickSzapiro-NOAA
Copy link
Collaborator

NickSzapiro-NOAA commented Jan 9, 2024 •
edited
Loading

@NickSzapiro-NOAA Are you running the RTs for this PR in order to post the logs?

I can run Orion and Hercules and Hera tonight after maintenance. Still need the user_sets_restname = true change first

@DeniseWorthen
Copy link
Collaborator

Thanks. EIther Hercules or Hera would be required (each has both Intel and gnu). For pre-testing, there is no reason to run on more than one dual compiler platform.

@jkbk2004
Copy link
Collaborator

@aerorahul can you sync up the branch? We will consider to combine with some other no baseline change PRs.

@jkbk2004 jkbk2004 mentioned this pull request Jan 10, 2024
Merged
41 tasks
@NickSzapiro-NOAA
Copy link
Collaborator

RegressionTests_hera.log
With code modification of user_sets_restname = true in tests/parm/ufs.configure.s2sw*, all regression tests pass on Hera (attached). Tested branch is on Hera at /scratch1/NCEPDEV/nems/Nick.Szapiro/review/uwm-rahul

@aerorahul
Copy link
Contributor Author

/scratch1/NCEPDEV/nems/Nick.Szapiro/review/uwm-rahul

Thanks @NickSzapiro-NOAA
I have made the update and set that variable to be true via the template.

jkbk2004 added a commit that referenced this pull request Jan 11, 2024
@jiandewang @gspetro-NOAA
@aerorahul @JeffBeck-NOAA @jkbk2004 @FernandoAndrade-NOAA @BrianCurtis-NOAA @zach1221
update MOM6 to its main repository 20231218 commit (disable FPEs) + A…
a837cfc 
…dd stochastic physics pattern update frequency options within SPP and LNDP ('sppint' and 'lndpint') #2077 + Updates to ufs.configure for use in global applications #2074 + Doc Updates #2030 (#2080)

* Update MOM6 to its main repository 20231218 updating (disable FPEs)

* Updates ufs.configure templates for use in global-applications.

* Adds the stochastic pattern interval (sppint) option to SPP and (lndpint) to the land perturbations (LNDP)

* Doc update for LND & CDEPS Input files required for land configurations

---------

Co-authored-by: “gspetro-NOAA” <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Jeff <[email protected]>
Co-authored-by: Jong Kim <[email protected]>
Co-authored-by: FernandoAndrade-NOAA <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: zach1221 <[email protected]>
@jkbk2004
Copy link
Collaborator

merged with #2080

@jkbk2004 jkbk2004 closed this Jan 11, 2024
@junwang-noaa junwang-noaa mentioned this pull request Jan 29, 2024
Closed
@aerorahul aerorahul deleted the feature/ufs_configure branch January 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

@NickSzapiro-NOAA NickSzapiro-NOAA NickSzapiro-NOAA approved these changes

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa

Assignees

@aerorahul aerorahul

@NickSzapiro-NOAA NickSzapiro-NOAA

Labels
None yet
Projects
No open projects
Model infrastructure development FY2024Q2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aerorahul @junwang-noaa @NickSzapiro-NOAA @DeniseWorthen @jkbk2004